Lunderberg opened a new pull request, #16595:
URL: https://github.com/apache/tvm/pull/16595

   Prior to this commit, `LiftTransformParams` would extract out all variable 
binding that have no runtime dependencies.  As a result, expressions such as 
`R.zeros([16], "int32")` would be extracted out into the parameter 
transformation, even though they do not depend on any parameters.
   
   This commit updates `LiftTransformParams` to only output variables that 
depend on at least one compile-time parameter.
   
   The unit test for this functionality also found that `relax::Call` was 
erroneously calling `MarkGraphNode` in `SEqualReduce` and `SHashReduce`.  This 
should only be called for nodes that have have reference equality, such as 
`relax::Var`, and not for composite objects.  This caused erroneous failures in 
the unit test when two instances of `R.zeros([16], "int32")` were being 
compared by reference equality in `StructuralEqual`.  These extra calls to 
`MarkGraphNode` have been removed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to