Lunderberg commented on code in PR #16599: URL: https://github.com/apache/tvm/pull/16599#discussion_r1499601132
########## tests/python/relax/test_transform_cse.py: ########## @@ -90,6 +88,12 @@ def foo() -> R.Tuple(R.Tensor((), dtype="int32"), R.Tensor((2, 2), dtype="int32" def test_repeated_inner_tuples(): + """CSE is only applied at variable bindings + + To remain consistent with the behavior of the normalizer, tuples + are kept as-is, even if they contain repeated sub-tuples. + """ Review Comment: Thank you. With how much discussion there was around the normalization with respect to `R.call_tir`, I figured it's best to match as much as possible to the normalization. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
