lhutton1 commented on code in PR #16612:
URL: https://github.com/apache/tvm/pull/16612#discussion_r1502309587
##########
include/tvm/runtime/data_type.h:
##########
@@ -110,7 +111,7 @@ class DataType {
return -lanes_as_int;
}
/*! \return whether type is a scalar type. */
- bool is_scalar() const { return lanes() == 1; }
+ bool is_scalar() const { return !is_scalable_vector() && lanes() == 1; }
Review Comment:
Due to placing a call to `is_scalable_vector()` before `lanes()`,
`is_scalar()` should work with scalable vectors in its current form, I'll add
some tests for this. I don't think we can simply `return
!is_scalable_or_fixed_length_vector()` as it wouldn't account for the case when
lanes == 0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
