yongwww commented on code in PR #16644:
URL: https://github.com/apache/tvm/pull/16644#discussion_r1503424843
##########
python/tvm/relax/frontend/onnx/onnx_frontend.py:
##########
@@ -2059,12 +2059,10 @@ def _sanitize_name(self, name: str) -> str:
if name == "":
return self._name_supply.fresh_name("empty_")
- new_name = name.replace(".", "_")
Review Comment:
it would be good to have a test case to cover this change. If this change is
going to align with the description, one option is to refine the description.
It would be good to avoid modifications to src/ir/supply.cc, given that it
serves as the foundation for numerous cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
