Lunderberg commented on code in PR #16642:
URL: https://github.com/apache/tvm/pull/16642#discussion_r1504921950
##########
python/tvm/relax/transform/transform.py:
##########
@@ -463,6 +463,16 @@ def KillAfterLastUse() -> tvm.ir.transform.Pass:
return _ffi_api.KillAfterLastUse() # type: ignore
+def ComputePrimValue() -> tvm.ir.transform.Pass:
+ """Compute all R.prim_value instances
Review Comment:
Hmm. I think this is another argument in favor of allowing `FuncStructInfo`
annotations for `PrimFunc` objects, as that would allow the generated
`PrimFunc` instances to be marked as pure functions. I'll add a unit test to
see how well that works for maintaining purity tracking when calling a pure
PrimFunc from a pure Relax function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
