slyubomirsky commented on PR #16634: URL: https://github.com/apache/tvm/pull/16634#issuecomment-1967667539
I had this issue come up in https://github.com/apache/tvm/pull/16569. I think these tests probably were not being executed before. I am also pretty sure it's safe to just remove those lines, as `__tvm_meta__` is not actually read anywhere. In my PR, I added a check in the parser to make sure that `decl_function` would only be called with function definitions, which raises a readable error message and prevents a segfault. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
