jwfromm commented on code in PR #16654:
URL: https://github.com/apache/tvm/pull/16654#discussion_r1506387235
##########
src/relax/op/image/resize.cc:
##########
@@ -105,14 +105,26 @@ StructInfo InferStructInfoResize2D(const Call& call,
const BlockBuilder& ctx) {
InferLayoutOutput InferLayoutResize2d(const Call& call,
const Map<String, Array<String>>&
desired_layouts,
const VarLayoutMap& var_layout_map) {
- ICHECK(NoDesiredLayout(call, desired_layouts));
+ const auto& it = desired_layouts.find("relax.image.resize2d");
const auto* attrs = call->attrs.as<Resize2DAttrs>();
ICHECK(attrs) << "Invalid Call";
- LayoutDecision layout = GetLayoutDecision(var_layout_map, call->args[0]);
+ LayoutDecision data_layout;
ObjectPtr<Resize2DAttrs> new_attrs = make_object<Resize2DAttrs>(*attrs);
- new_attrs->layout = TransposeLike(attrs->layout, InitialLayout(4),
layout->layout).name();
- return InferLayoutOutput({layout, InitialNLayout(call->args[1])}, {layout},
Attrs(new_attrs));
+
+ if (it != desired_layouts.end()) {
Review Comment:
I think this only changes the behavior when rewriting layouts, which I test
explicitly in `test_transform_convert_layout.py`. What additional tests do you
think should be added?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
