vinx13 commented on code in PR #16652:
URL: https://github.com/apache/tvm/pull/16652#discussion_r1506643180
##########
python/tvm/topi/cuda/scan.py:
##########
@@ -363,20 +378,10 @@ def exclusive_scan(
"""
def do_scan(data, output_dtype):
- target = tvm.target.Target.current()
# TODO: add support for a prod_scan
- if (
- target
- and binop == tvm.tir.generic.add
- and (
- can_use_thrust(target, "tvm.contrib.thrust.sum_scan")
- or can_use_rocthrust(target, "tvm.contrib.thrust.sum_scan")
- )
- ):
- return scan_thrust(
- data, output_dtype, exclusive=True,
return_reduction=return_reduction, binop=binop
- )
+ if _can_use_scan_thrust(binop):
+ return scan_thrust(data, output_dtype,
return_reduction=return_reduction, binop=binop)
Review Comment:
let's pass `exclusive=True` explicitly here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
