tqchen commented on PR #16653: URL: https://github.com/apache/tvm/pull/16653#issuecomment-1985781508
Chimingin here a bit, i think the overall we would like to gradually move away from relying on e2e tests. in this case, there are usually two parts: - T0: The frontend imports into the right operator, unittested through structural equality especially as we migrate towards relax - T1: The overall accuracy issue of a particular pattern that caused backend to regress, in this case usually it is desirable to directly construct the IR in low level possible and test that Moving forward, i think we should decouple T0 and T1 (into likely separate PRs). This would help us to build more robust tests that runs faster and ensure unittest cases remain more UT, runs faster and can locate errors more effectively -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
