Lunderberg commented on code in PR #16721:
URL: https://github.com/apache/tvm/pull/16721#discussion_r1526222825


##########
src/tir/transforms/plan_update_buffer_allocation_location.cc:
##########
@@ -32,21 +32,21 @@
 namespace tvm {
 namespace tir {
 
-class CollectUnmanagedAllocations : public StmtExprVisitor {
+class CollectManagedAllocations : public StmtExprVisitor {

Review Comment:
   Good point.  This was a bug that I encountered and fixed during 
implementation.  The TIR build pipeline made some simplifying assumptions about 
the TIR that it would receive, which the new legalization functions do not 
follow.
   
   I've spun it out into an independent 
[PR#16726](https://github.com/apache/tvm/pull/16726).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to