Lunderberg commented on PR #16730: URL: https://github.com/apache/tvm/pull/16730#issuecomment-2002439855
Agreed, and I think this PR helps move in that direction. By separating out implementation of `rewrite_bindings` (`BlockPatternRewriter`) from the implementation of `rewrite_call` (`ExprPatternRewriter`), the improvements needed for `rewrite_bindings` should be easier to make. I wanted to separate the two implementations before making an improvement specific to `rewrite_call`, to avoid introducing complexity in `rewrite_bindings`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
