slyubomirsky commented on PR #16744: URL: https://github.com/apache/tvm/pull/16744#issuecomment-2008297192
I think this idea is very promising, though we should be certain of some corners of the design: 1. Is there any invariant we want to unknown purity? Do we expect all unknown purities to be resolved by a pass? 2. Is unknown purity permitted in a DF block? We could defer checking it until after (say) a purity inference pass. However, deferring the check now means that the purity inference pass is another phase ordering dependency (not a big deal, but users need to remember to use it after any pass that adds new functions to the module). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
