Johnson9009 opened a new issue, #16753:
URL: https://github.com/apache/tvm/issues/16753

   When using OpenCL + Graph Executor + set_input_zero_copy, we found below 
code will raise exception, actually we know the NDArray is allocated by the 
OpenCL device API, it should satisfy the alignment requirement.
   
![image](https://github.com/apache/tvm/assets/19802523/5d277aed-b3ce-47fb-b5ae-7b7034513e4d)
   
   After browsing some code of OpenCL device API, we found that OpenCL device 
API finally will return a pointer of host structure `BufferDescriptor`,  and 
this pointer is convert to `void*`, and store in the `data` field of `DLTensor`.
   
![image](https://github.com/apache/tvm/assets/19802523/a7cdc791-6de8-4892-b8c3-6256254e6941)
   This is the reason why the 1st figure alignment check failed, the vulkan 
device API use the same mechanism, so it have the same problem.
   
   Why Relay VM haven't meet this failed check?
   
![image](https://github.com/apache/tvm/assets/19802523/2490c964-f34b-40c5-9351-036c9d9338b6)
   
![image](https://github.com/apache/tvm/assets/19802523/6b055194-d794-4bd6-a1ff-0a3d31cbe9f7)
   Acturally Relay VM is impacted by this issue too, the different is Relay VM 
won't raise exception, but do a non-need copy.
   
   Even through we will pass the aligement argument to the interface ` virtual 
void* AllocDataSpace(Device dev, size_t nbytes, size_t alignment,  DLDataType 
type_hint) = 0;` of class `DeviceAPI`, but I found except CPU, it seems all of 
other device can't avoid to specify aligment when alloc data through their 
runtime API.
   So why we need this alignment? can we deleted these checks?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to