Lunderberg commented on code in PR #16785:
URL: https://github.com/apache/tvm/pull/16785#discussion_r1539402961
##########
tests/python/relax/test_frontend_nn_packing.py:
##########
@@ -25,7 +25,9 @@ def _iter_binding_names(mod):
"""Helper function to compare the names of relax variables"""
for block in mod["forward"].body.blocks:
for binding in block.bindings:
- yield binding.var.name_hint
+ # Relax variable names may contain '.' even though it
+ # cannot be expressed in TVMScript.
Review Comment:
I could go either way. It's nice to have the 1:1 mapping between Relax and
TVMScript, which would forbid the period within a relax variable name.
However, it's also nice to have a 1:1 mapping between a Relax function
parameter and weight tensor's name in a pytorch or safetensor file, which are
usually written with a period in the name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
