cgerum commented on code in PR #16712:
URL: https://github.com/apache/tvm/pull/16712#discussion_r1545749330
##########
rust/tvm/src/ir/expr.rs:
##########
@@ -94,9 +94,9 @@ external! {
fn _as_text(object: ObjectRef, show_meta_data: i32, annotate:
runtime::Function) -> TString;
}
-pub fn as_text<T: IsObjectRef>(object: T) -> String {
+pub fn as_text<T: IsObjectRef>(object: T, show_meta_data: i32) -> String {
Review Comment:
> Does the new argument break existing callsites of `as_text`? Since we
can't add default parameters to preserve backwards compatibility, I'm wondering
if this should be updated to use the builder pattern in the future.
You mean `object.with_metadata().as_text()`? Unfortunately I am not sure
wether backwards compatibility in this case is important enough, to warrant the
increased API complexity.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
