Lunderberg commented on PR #16801: URL: https://github.com/apache/tvm/pull/16801#issuecomment-2032356395
Agreed, it would be good to avoid having too many special cases. The intent was to allow optimization passes, or API-altering passes, to be part of an end-to-end pipeline while only impacting a few functions within the module. (e.g. Applying `LazyGetInput` to the result of `LiftTransformParams`, but not to any of the inference functions.) If it requires more special cases in general, I think the `ApplyPassToFunction` could be improved by replacing all non-matching functions with `relax::ExternFunc`, rather than filtering them out altogether. That way, the inner transform could operate on a well-formed `IRModule`, but wouldn't be able to mutate other functions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
