Lunderberg commented on PR #16833: URL: https://github.com/apache/tvm/pull/16833#issuecomment-2034835923
Thank you! CI has found a surprising number of failures for this check. It looks like the new check requiring the same `GlobalVar` and `Function` struct info has caught an issue with TVMScript. The GlobalVar instances are generated based solely on the function signature, where the `Function` instances can also infer the return type from the body. For now, I think I'll make the check looser, using `IsBaseOf` instead of `StructuralEqual`. That would require the `GlobalVar` to be an accurate representation of the function, without requiring it to be a complete representation of the function. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
