csullivan commented on code in PR #16865:
URL: https://github.com/apache/tvm/pull/16865#discussion_r1558410678
##########
src/target/source/codegen_cuda.cc:
##########
@@ -1260,6 +1260,20 @@ void CodeGenCUDA::VisitExpr_(const BroadcastNode* op,
std::ostream& os) { // NO
return;
}
+ if (op->dtype.is_float8()) {
+ int lanes = op->dtype.lanes();
+ ICHECK(lanes == 1 || lanes == 2 || lanes == 4);
+ std::string v = PrintExpr(op->value);
+ PrintType(op->dtype, os);
Review Comment:
nit, only because it took me more than 30 seconds to digest this
```suggestion
# Implicit conversion from float back to fp8
PrintType(op->dtype, os);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
