mengshyu commented on code in PR #16854:
URL: https://github.com/apache/tvm/pull/16854#discussion_r1559380223


##########
python/tvm/target/detect_target.py:
##########
@@ -58,6 +58,17 @@ def _detect_rocm(dev: Device) -> Target:
     )
 
 
+def _detect_opencl(dev: Device) -> Target:
+    return Target(
+        {
+            "kind": "opencl",

Review Comment:
   It seems there is no argument for '-device=adreno' in API 
[Target.from_device.](https://github.com/apache/tvm/blob/main/python/tvm/target/target.py#L154)
   
   This PR intends to fix weight conversion for MLC LLM on OrangePi 
([#1557](https://github.com/mlc-ai/mlc-llm/issues/1557)), assuming there are no 
other issues. I would like to merge it first. If you have any suggestions, 
perhaps we can create another issue to discuss. Thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to