mbaret commented on issue #5277: [BYOC] Refine AnnotateTarget and 
MergeCompilerRegion Passes
URL: https://github.com/apache/incubator-tvm/pull/5277#issuecomment-610851491
 
 
   Thanks for this, a few high level comments first.
   
   - Could we separate some of these changes out into separate PRs? In 
particular, separating bug fixes from features so we can get them in quickly.
   - Am I right to think that the intended flow here is to only run 
AnnotateTarget once? I'm not sure how we would use it in the case where we have 
two codegens, one that wants to see the graph with QNN ops and the other than 
wants the graph without them.
   - What's the advantage of this multi-target approach over running the entire 
partitioning pipeline multiple times?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to