krishnaraj36 commented on PR #16932:
URL: https://github.com/apache/tvm/pull/16932#issuecomment-2081867248

   > Thanks @krishnaraj36 for the great PR and significant perf improvement.
   > 
   > However, `q4f16_0` should be `outer_reduction` as the layout is `KN`. I 
wonder why the rule is named as `sch_adreno_inner_reduction`
   > 
   > If it's a naming issue, we can replace the current rule of 
`sch_outer_reduction` as it is specially designed for android only
   
   Thanks for your review. 
   Yes, Its naming issue, I have made changes to func naming to make sense.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to