tqchen commented on code in PR #16976:
URL: https://github.com/apache/tvm/pull/16976#discussion_r1595398017


##########
src/target/source/intrin_rule_webgpu.cc:
##########
@@ -113,6 +113,8 @@ TVM_REGISTER_OP("tir.trunc")
 // extra dispatch
 TVM_REGISTER_OP("tir.erf").set_attr<FLowerIntrinsic>("webgpu.FLowerIntrinsic", 
DispatchFastErf);
 
+TVM_REGISTER_OP("tir.dot4I8Packed").set_attr<FLowerIntrinsic>("webgpu.FLowerIntrinsic",
 DispatchPureExtern<Direct>);

Review Comment:
   sorry i was not being clear, for tir, it is better to have a common name dp4a



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to