Lunderberg commented on PR #16999: URL: https://github.com/apache/tvm/pull/16999#issuecomment-2120494893
Thank you for the fix, and that definitely sounds like a good fix to have. What effect did the non-const `.rodata` have, and can we also add a test case for it? My naive guess would have been that the OS-level protections against writing to the `.rodata` section would have still been present, but language-level const checks wouldn't have been, and that any attempted writes to the `.rodata` fields would have resulted in runtime errors. Was that the case, and if so can we assert that a compile-time error is raised for these failures instead? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
