tqchen commented on code in PR #17022:
URL: https://github.com/apache/tvm/pull/17022#discussion_r1613292617


##########
src/relax/transform/fuse_ops.cc:
##########
@@ -262,16 +262,11 @@ class GraphCreator : public ExprVisitor {
     IndexedForwardGraph::Node* leaf_node = nullptr;
     if (it != graph_.node_map.end()) {
       leaf_node = it->second;
-    } else if (leaf_expr->IsInstance<ConstantNode>() || 
leaf_expr->IsInstance<ShapeExprNode>() ||
-               leaf_expr->IsInstance<PrimValueNode>() || 
leaf_expr->IsInstance<StringImmNode>() ||

Review Comment:
   Is this intended change? Seems that we should consider sass where constant 
value(and there may not be a binding pt)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to