jhong92-pro commented on PR #17015: URL: https://github.com/apache/tvm/pull/17015#issuecomment-2133410250
@leandron, I reviewed the links in `request_hook.py` and found that other links include the commit hash in the URL to ensure they remain unchanged. I think it would be beneficial to update the links to include the commit hash to prevent future changes, rather than changing to a new URL. What do you think? https://github.com/apache/tvm/blob/27a3b90105c27135924a357fb72c4d6bfa5e33d7/tests/scripts/request_hook/request_hook.py#L122-L123 ``` grep -r "resnet50-v2-7\.onnx" * apps/wasm-standalone/wasm-graph/tools/build_graph_lib.py: "resnet50-v2-7.onnx" apps/wasm-standalone/wasm-graph/tools/build_graph_lib.py: model_path = download_testdata(model_url, "resnet50-v2-7.onnx", module="onnx") gallery/tutorial/tvmc_command_line_driver.py:# wget https://github.com/onnx/models/raw/b9a54e89508f101a1611cd64f4ef56b9cb62c7cf/vision/classification/resnet/model/resnet50-v2-7.onnx gallery/tutorial/tvmc_command_line_driver.py:# resnet50-v2-7.onnx gallery/tutorial/tvmc_command_line_driver.py:# resnet50-v2-7.onnx gallery/tutorial/tvmc_command_line_driver.py:# resnet50-v2-7.onnx gallery/tutorial/tvmc_command_line_driver.py:# resnet50-v2-7.onnx gallery/tutorial/autotvm_relay_x86.py: "resnet50-v2-7.onnx" gallery/tutorial/autotvm_relay_x86.py:model_path = download_testdata(model_url, "resnet50-v2-7.onnx", module="onnx") gallery/tutorial/tvmc_python.py: wget https://github.com/onnx/models/raw/b9a54e89508f101a1611cd64f4ef56b9cb62c7cf/vision/classification/resnet/model/resnet50-v2-7.onnx gallery/tutorial/tvmc_python.py: mv resnet50-v2-7.onnx my_model.onnx tests/python/driver/tvmc/conftest.py: file_to_download = "resnet50-v2-7.onnx" tests/python/contrib/test_bnns/test_onnx_topologies.py: "ResNet50-v2": "vision/classification/resnet/model/resnet50-v2-7.onnx", tests/python/relay/collage/menangerie.py: "filename": "resnet50-v2-7.onnx", tests/scripts/request_hook/request_hook.py: "https://github.com/onnx/models/raw/bd206494e8b6a27b25e5cf7199dbcdbfe9d05d1c/vision/classification/resnet/model/resnet50-v2-7.onnx": f"{BASE}/onnx/models/raw/bd206494e8b6a27b25e5cf7199dbcdbfe9d05d1c/vision/classification/resnet/model/resnet50-v2-7.onnx", tests/scripts/request_hook/request_hook.py: "https://github.com/onnx/models/raw/main/vision/classification/resnet/model/resnet50-v2-7.onnx": f"{BASE}/2022-10-05/resnet50-v2-7.onnx", ``` ``` grep -r "mobilenetv2-7\.onnx" * tests/python/contrib/test_hexagon/test_models.py: model_url = "https://github.com/onnx/models/raw/main/vision/classification/mobilenet/model/mobilenetv2-7.onnx"; # pylint: disable=line-too-long tests/python/contrib/test_hexagon/test_models.py: model_url, "mobilenetv2-7.onnx", module="onnx" tests/python/contrib/test_hexagon/test_relax_integration.py: model_url = "https://github.com/onnx/models/raw/main/vision/classification/mobilenet/model/mobilenetv2-7.onnx"; tests/python/contrib/test_hexagon/test_relax_integration.py: model_url, "mobilenetv2-7.onnx", module="onnx" tests/python/contrib/test_bnns/test_onnx_topologies.py: "MobileNet-v2": "vision/classification/mobilenet/model/mobilenetv2-7.onnx", tests/scripts/request_hook/request_hook.py: "https://github.com/onnx/models/raw/main/vision/classification/mobilenet/model/mobilenetv2-7.onnx": f"{BASE}/onnx/models/raw/main/vision/classification/mobilenet/model/mobilenetv2-7.onnx", ``` For example, `https://github.com/onnx/models/raw/main/vision/classification/mobilenet/model/mobilenetv2-7.onnx` to `https://github.com/onnx/models/raw/bd206494e8b6a27b25e5cf7199dbcdbfe9d05d1c/vision/classification/mobilenet/model/mobilenetv2-7.onnx` and `https://github.com/onnx/models/raw/main/vision/classification/resnet/model/resnet50-v2-7.onnx` to `https://github.com/onnx/models/raw/bd206494e8b6a27b25e5cf7199dbcdbfe9d05d1c/vision/classification/resnet/model/resnet50-v2-7.onnx` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
