ekalda commented on code in PR #17046:
URL: https://github.com/apache/tvm/pull/17046#discussion_r1620642225
##########
src/arith/rewrite_simplify.cc:
##########
@@ -1136,8 +1136,15 @@ PrimExpr RewriteSimplifier::Impl::VisitExpr_(const
FloorDivNode* op) {
x + floordiv(y, z), CanProveGreaterEqual(z.Eval(), 0));
TVM_TRY_REWRITE_IF(matches_one_of(floordiv(y + x * z, z), floordiv(y + z *
x, z)),
floordiv(y, z) + x, CanProveGreaterEqual(z.Eval(), 0));
+ TVM_TRY_REWRITE_IF(floordiv(x * z * c1 + y, z * c1), x + floordiv(y, z *
c1),
+ CanProveGreaterEqual(z.Eval() * c1.Eval(), 0));
TVM_TRY_REWRITE_IF(floordiv(x - floormod(x, c1), c1), floordiv(x, c1),
c1.Eval()->value != 0);
+
+ // Scalable divisor
+ TVM_TRY_REWRITE_IF(floordiv(x, y), ZeroWithTypeLike(x),
+ ContainsVscaleCall(y.Eval()) &&
CanProveGreaterEqual(x.Eval(), 0) &&
+ CanProveGreaterEqual(y.Eval(), 0) &&
CanProve(x.Eval() < y.Eval()));
Review Comment:
Nit: `CanProveGreaterEqual(y.Eval(), 0)` seems redundant here (but I don't
oppose keeping it for the sake of clarity)
##########
src/arith/rewrite_simplify.cc:
##########
@@ -1136,8 +1136,15 @@ PrimExpr RewriteSimplifier::Impl::VisitExpr_(const
FloorDivNode* op) {
x + floordiv(y, z), CanProveGreaterEqual(z.Eval(), 0));
TVM_TRY_REWRITE_IF(matches_one_of(floordiv(y + x * z, z), floordiv(y + z *
x, z)),
floordiv(y, z) + x, CanProveGreaterEqual(z.Eval(), 0));
+ TVM_TRY_REWRITE_IF(floordiv(x * z * c1 + y, z * c1), x + floordiv(y, z *
c1),
+ CanProveGreaterEqual(z.Eval() * c1.Eval(), 0));
Review Comment:
If `z * c1 == 0` we get a division by zero? I hope it would not be allowed
in constructing the `floordiv`, but maybe we shouldn't explicitly allow it in
rewrite rules.
##########
src/arith/rewrite_simplify.cc:
##########
@@ -1230,6 +1237,14 @@ PrimExpr RewriteSimplifier::Impl::VisitExpr_(const
FloorModNode* op) {
ZeroWithTypeLike(x),
CanProveEqual(y.Eval() - z.Eval(), 0) || CanProveEqual(y.Eval() +
z.Eval(), 0));
+ TVM_TRY_REWRITE_IF(floormod(x * z * c1 + y, z * c1), floormod(y, z * c1),
Review Comment:
Same as before, unless I'm missing something, we're allowing modulo 0 here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
