mshr-h commented on code in PR #17123:
URL: https://github.com/apache/tvm/pull/17123#discussion_r1659514682
##########
python/tvm/contrib/hexagon/session.py:
##########
@@ -286,7 +286,9 @@ def get_graph_debug_executor(
graph_json, graph_debug_mod, self.device, dump_root=str(dump_root)
)
- def get_executor_from_factory(self, module: Union[ExecutorFactoryModule,
relax.Executable]):
+ def get_executor_from_factory(
+ self, module: Union[ExecutorFactoryModule, relax.Executable],
hexagon_arch: str = "v68"
+ ):
"""Create a local GraphModule which consumes a remote libmod.
Parameters
Review Comment:
I think we need to add the docstring for `hexagon_arch`.
##########
python/tvm/contrib/hexagon/session.py:
##########
@@ -286,7 +286,9 @@ def get_graph_debug_executor(
graph_json, graph_debug_mod, self.device, dump_root=str(dump_root)
)
- def get_executor_from_factory(self, module: Union[ExecutorFactoryModule,
relax.Executable]):
+ def get_executor_from_factory(
+ self, module: Union[ExecutorFactoryModule, relax.Executable],
hexagon_arch: str = "v68"
+ ):
"""Create a local GraphModule which consumes a remote libmod.
Parameters
Review Comment:
Please update the docstring for `hexagon_arch`.
##########
python/tvm/contrib/hexagon/session.py:
##########
@@ -286,7 +286,9 @@ def get_graph_debug_executor(
graph_json, graph_debug_mod, self.device, dump_root=str(dump_root)
)
- def get_executor_from_factory(self, module: Union[ExecutorFactoryModule,
relax.Executable]):
+ def get_executor_from_factory(
+ self, module: Union[ExecutorFactoryModule, relax.Executable],
hexagon_arch: str = "v68"
+ ):
"""Create a local GraphModule which consumes a remote libmod.
Parameters
Review Comment:
We do need docstring for `hexagon_arch`.
##########
python/tvm/contrib/hexagon/session.py:
##########
@@ -286,7 +286,9 @@ def get_graph_debug_executor(
graph_json, graph_debug_mod, self.device, dump_root=str(dump_root)
)
- def get_executor_from_factory(self, module: Union[ExecutorFactoryModule,
relax.Executable]):
+ def get_executor_from_factory(
+ self, module: Union[ExecutorFactoryModule, relax.Executable],
hexagon_arch: str = "v68"
+ ):
"""Create a local GraphModule which consumes a remote libmod.
Parameters
Review Comment:
We do need docstring for `hexagon_arch` parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
