sunggg commented on code in PR #17158:
URL: https://github.com/apache/tvm/pull/17158#discussion_r1679655697
##########
src/arith/rewrite_simplify.cc:
##########
@@ -697,7 +698,7 @@ PrimExpr RewriteSimplifier::Impl::VisitExpr_(const SubNode*
op) {
TVM_TRY_RECURSIVE_REWRITE(x - (y + c1), (x - y) + (0 - c1));
TVM_TRY_RECURSIVE_REWRITE(x - (y - z), (x + z) - y);
TVM_TRY_RECURSIVE_REWRITE(x - y * c1, x + y * (0 - c1));
- } else if (op->dtype.is_float()) {
+ } else {
Review Comment:
For currently unsupported integer types, is there any reason to take this
path rather than path for the index types? They are also integers and this path
has more rules defined. But, I'm not currently sure if it supports negative
index but if it does not, it could be effectively same with unsigned integer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
