Lunderberg commented on issue #17176: URL: https://github.com/apache/tvm/issues/17176#issuecomment-2252835720
To resolve this, and to prevent similar bugs from occurring in the future, I think we should make the following changes: 1) When `AttachGlobalSymbol` changes the name of a function, it must also replace the `GlobalVar` used to refer to that function. All occurrences of the old `GlobalVar` across the `IRModule` must then be replaced by the new `GlobalVar`. 2) The well-formed checker should validate that the `GlobalVar` and `"global_symbol"` match across all functions, not just relax functions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
