Lunderberg commented on issue #17225: URL: https://github.com/apache/tvm/issues/17225#issuecomment-2260948263
The names used for each pass are purely for human-readability, and aren't required to have any specific format. By convention, passes that impacted Relay functions had no prefix, while passes that impacted TIR functions had a `"tir."` prefix. Most of the Relax passes inherited the naming convention from Relay. Unfortunately, this means that Relay and Relax transforms may have the same name (e.g. the name `"DeadCodeElimination"` is used both [here](https://github.com/apache/tvm/blob/main/src/relax/transform/dead_code_elimination.cc#L187) for Relax and [here](https://github.com/apache/tvm/blob/main/src/relay/transforms/dead_code.cc#L576) for Relay). Since user scripts may specify per-pass config options by name (e.g. `with PassContext(disabled_pass=["some_pass_name"])`), updating the names to all have unique prefixes would break backwards compatibility. It may be worth it at some point to avoid duplication, and to have an explicit IR type as part of every transform, but hasn't been a priority. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
