tqchen commented on code in PR #16183:
URL: https://github.com/apache/tvm/pull/16183#discussion_r1704119766
##########
include/tvm/runtime/c_runtime_api.h:
##########
@@ -207,6 +209,7 @@ typedef DLTensor* TVMArrayHandle;
*/
typedef union {
int64_t v_int64;
+ bool v_bool;
Review Comment:
likely v_bool is not needed and we can simply store value in `v_int64 `,
this can help to reduce the switch cases, and also make all value types as 64
bit, might help kernel passing handling to reduce cases as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
