CharlieFRuan opened a new pull request, #17250:
URL: https://github.com/apache/tvm/pull/17250

   This PR fixes an issue introduced in 
https://github.com/apache/tvm/pull/17005. `deviceLostIsError` was introduced to 
make sure intentional `dispose()` (hence webgpu's `destroy()`) does not cause 
device lost callback to treat it as an error. However, we cannot set 
`deviceLostIsError` immediately to true after calling `this.lib.dispose()` 
(which calls `device.destroy()`) because WebGPU is asynchronous. Otherwise, we 
would trigger the device lost callback when calling `Instance.dispose()` to 
destroy device intentionally.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to