Lunderberg commented on PR #17332: URL: https://github.com/apache/tvm/pull/17332#issuecomment-2329257393
This validation exposed a bug in `StructInfoLCA`, which only inspected the datatype of `PrimStructInfo` and not the known value. This bug was introduced in https://github.com/apache/tvm/pull/15577, which added tracking fo known `PrimStructInfo`, but didn't update `StructInfoLCA`. This bug would result in incorrect known value annotations in the `StructInfo`, after a conditional statement. Since these annotations are later used to simplify known expressions, this bug could have resulted in incorrect simplifications. The bug in `StructInfoLCA` is fixed as part of this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
