hlu1 commented on issue #5301: [NDArray] Set NDArray::Container.shape_ in NDArray::FromDLPack URL: https://github.com/apache/incubator-tvm/pull/5301#issuecomment-611909315 Another thing that's related: ``` std::vector<int64_t> NDArray::Shape() const { return get_mutable()->shape_; } ``` https://github.com/apache/incubator-tvm/blob/master/src/runtime/ndarray.cc#L251-L253 If we don't set `shape_` in `NDArray::FromDLPack`, we'll need to fix `NDArray::Shape()` to make sure it returns the right shape info.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
