zhiics commented on a change in pull request #5271: [RUNTIME] Introduce RValue
reference(move) support to TypedPackedFunc
URL: https://github.com/apache/incubator-tvm/pull/5271#discussion_r405964246
##########
File path: include/tvm/runtime/packed_func.h
##########
@@ -547,12 +536,52 @@ class TVMArgValue : public TVMPODValue_ {
const TVMValue& value() const {
return value_;
}
+
template<typename T,
typename = typename std::enable_if<
std::is_class<T>::value>::type>
inline operator T() const;
};
+/*!
+ * \brief Internal auxiliary struct for TypedPackedFunc to indicate a movable
argument.
+ *
+ * We can only construct a movable argument once from a single argument
position.
+ * If the argument is passed as RValue reference, the result will be moved.
+ * We should only construct a MovableArg from a argument once,
Review comment:
s/a/an
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
