MasterJH5574 commented on code in PR #17506:
URL: https://github.com/apache/tvm/pull/17506#discussion_r1842900900
##########
python/tvm/relax/frontend/nn/llm/position_embedding.py:
##########
@@ -341,11 +427,18 @@ def _rope( # pylint: disable=too-many-arguments
pos * scale, d, rotary_dim, theta, "float32", **kwargs
)
cos = cos_freq * x[s, h, d].astype("float32")
- sin = sin_freq * tir.if_then_else(
- d < rotary_dim // 2,
- -x[s, h, d + rotary_dim // 2],
- x[s, h, d - rotary_dim // 2],
- ).astype("float32")
+ if rope_scaling["rope_type"] == "gptj":
Review Comment:
I'm not sure if it's the reason, but I guess maybe we can try `"rope_type"
in rope_scaling and rope_scaling["rope_type"] == "gptj"`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
