HongHongHongL commented on code in PR #17536:
URL: https://github.com/apache/tvm/pull/17536#discussion_r1849672780
##########
tests/python/relax/test_frontend_onnx.py:
##########
@@ -1022,6 +1022,57 @@ def _verify_conv(input_shape, weight_shape):
_verify_conv([3, 4, 32, 32, 32], [2, 4, 3, 3, 3]) # group=2
[email protected]("stride", [1, 2])
Review Comment:
I got 'Dilation not supported for AutoPadType::SAME_UPPER or
AutoPadType::SAME_LOWER' while using onnxruntime. If I add
'@pytest.mark.parametrize("auto_pad", ["SAME_UPPER", "SAME_LOWER", "VALID",
"NOTSET"])', I should skip dilation=2 for "SAME_UPPER" and "SAME_LOWER". I'm
just not sure if this approach is okay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
