cbalint13 commented on code in PR #17547:
URL: https://github.com/apache/tvm/pull/17547#discussion_r1863664496


##########
src/target/llvm/codegen_llvm.cc:
##########
@@ -169,7 +169,11 @@ void CodeGenLLVM::InitTarget() {
   llvm::TargetMachine* tm = llvm_target_->GetOrCreateTargetMachine();
   module_->setTargetTriple(tm->getTargetTriple().str());
   module_->setDataLayout(tm->createDataLayout());
+#if TVM_LLVM_VERSION >= 200
+  data_layout_ = std::make_unique<llvm::DataLayout>(module_->getDataLayout());

Review Comment:
   I am asking for a bit more conservative ways due to very frequent llvm 
changes, it helps keep the track a bit better across version deviations and 
maintainers. Thanks for understanding 🙏.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to