PatrikPerssonInceptron commented on code in PR #17598:
URL: https://github.com/apache/tvm/pull/17598#discussion_r1923479734
##########
src/tir/analysis/estimate_flops.cc:
##########
@@ -138,6 +138,7 @@ class FlopEstimator : private ExprFunctor<TResult(const
PrimExpr& n)>,
}
TResult VisitExpr_(const BufferLoadNode* op) override { return TResult(); }
+ TResult VisitStmt_(const AttrStmtNode* op) override { return TResult(); }
Review Comment:
I was a bit unsure about this when I added the node. My original thought was
that the attribute node would only serve to hold values for downstream passes
such as codegen and would not be converted to executable code and therefore
should not be in the flops estimate.
I updated the visitor to visit the body and value of AttrStmtNode, however
I can undo this if it is not correct.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
