MasterJH5574 commented on code in PR #17752:
URL: https://github.com/apache/tvm/pull/17752#discussion_r2013164567


##########
python/tvm/relax/frontend/torch/exported_program_translator.py:
##########
@@ -45,7 +45,7 @@ def _hardtanh(self, node: fx.Node) -> relax.Expr:
 
     ########## Neural Network ##########
 
-    def _batch_norm_legit_no_training(self, node: fx.Node) -> relax.Var:
+    def _batch_norm(self, node: fx.Node, training) -> relax.Var:

Review Comment:
   Good to add a type annotation in any of followup PRs.
   ```suggestion
       def _batch_norm(self, node: fx.Node, training: bool) -> relax.Var:
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to