tqchen commented on PR #17920:
URL: https://github.com/apache/tvm/pull/17920#issuecomment-2852623515
The changes started from an initial code poc in collaboration with
@junrushao one year ago.
Then it independently evolved driven by the needs of a full upgrade in tree,
while
keeping things minimal and lightweight. We will work on upgrades in the
coming PRs, including areas
such as reflection, phasing out legacy redirections etc.
Some upgrade note of the dependent code
- For general containers like `Map<ObjectRef, ObjectRef>`, consider use
`Map<Any, Any>` instead
- Use `ffi::Function` in place of `PackedFunc`
- Any now requires explicit cast `cast<T>` or `.as<T>()` (returns optional)
for better type safety
- Likely one can insert `args[i].cast<T>()` to explicitly cast to T, or
use typed version
- Checkout [test
cases](https://github.com/apache/tvm/tree/refactor-s3/ffi/tests/cpp)
for some of the example usages
Because of its nature, I would recommend rebase merge of the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
