DerrickYLJ commented on code in PR #18027:
URL: https://github.com/apache/tvm/pull/18027#discussion_r2119395395
##########
include/tvm/runtime/data_type.h:
##########
@@ -261,20 +294,80 @@ class DataType {
* \return The constructed data type.
*/
static DataType BFloat(int bits, int lanes = 1) { return DataType(kDLBfloat,
bits, lanes); }
+ /*!
+ * \brief Construct NV float8 e3m4 datatype.
+ * \param lanes The number of lanes
+ * \return The constructed data type.
+ */
+ static DataType NVFloat8E3M4(int lanes = 1) { return DataType(kFloat8_e3m4,
8, lanes); }
+
/*!
* \brief Construct NV float8 e4m3 datatype.
* \param lanes The number of lanes
* \return The constructed data type.
*/
- static DataType NVFloat8E4M3(int lanes = 1) { return
DataType(kFloat8_e4m3fn, 8, lanes); }
+ static DataType NVFloat8E4M3(int lanes = 1) { return DataType(kFloat8_e4m3,
8, lanes); }
+
+ /*!
+ * \brief Construct NV float8 e4m3b11fnuz datatype.
+ * \param lanes The number of lanes
+ * \return The constructed data type.
+ */
+ static DataType NVFloat8E4M3B11FNUZ(int lanes = 1) {
+ return DataType(kFloat8_e4m3b11fnuz, 8, lanes);
+ }
+
+ /*!
+ * \brief Construct NV float8 e4m3fn datatype.
+ * \param lanes The number of lanes
+ * \return The constructed data type.
+ */
+ static DataType NVFloat8E4M3FN(int lanes = 1) { return
DataType(kFloat8_e4m3fn, 8, lanes); }
+
+ /*!
+ * \brief Construct NV float8 e4m3fnuz datatype.
+ * \param lanes The number of lanes
+ * \return The constructed data type.
+ */
+ static DataType NVFloat8E4M3FNUZ(int lanes = 1) { return
DataType(kFloat8_e4m3fnuz, 8, lanes); }
Review Comment:
In this case, should we directly delete these datatypes since
`__nv_fp8_e4m3`, `__nv_fp8_e5m2`, `__nv_fp8_e8m0`, and `__nv_fp8_e4m3` already
exist?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
