tqchen commented on PR #18040:
URL: https://github.com/apache/tvm/pull/18040#issuecomment-2944480852

   > Q1: What’s the difference between decomposing an op using Relax ops vs. 
TOPI ops vs. TIR?
   
   Given this is relax importer, we can chose either options as long as the 
correctness match. When possible, if we can decompose via relax then legalize, 
it gives most opportunities for possible choice of lowering path. We should aim 
to reduce total number of core relax ops
   
   > Q2/ Q3
   
   yes ideally we should have a nightly test validating the correctness
   
   We can add such tests to
   
   https://github.com/apache/tvm/tree/main/tests/python/nightly
   
   nightly/relax/test_relax_op_numeric.py
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to