tqchen commented on PR #18059: URL: https://github.com/apache/tvm/pull/18059#issuecomment-2976288988
great point, right now we plan to only replace reflection visitor. The ffi::Function and other elements will be preserved and likely built on top with optional extra metadata. Note that it is still ffi::Function under the hood, and python side decorator will be preserved, the method binding will allow us to expose private method funtions (x.__foo) for example, and write x.foo in python to call into x.__foo similar to the current way. We will also likely preserve the global function registration so if we want to choose to expose methods as global functions it will continue to work. I expect most code likely will be like this. It will indeed allow full method decoration on c++ side with meta-data, but also easily shifts some to c++ if needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
