LeiWang1999 commented on code in PR #18330:
URL: https://github.com/apache/tvm/pull/18330#discussion_r2404112140
##########
src/arith/const_int_bound.cc:
##########
@@ -324,6 +343,24 @@ class ConstIntBoundAnalyzer::Impl
if (b.min_value > 0) {
int64_t b_max_cap = InfAwareAdd(b.max_value, -1);
+ // Try to get tighter bounds using modular set information
+ if (parent_ && b.min_value == b.max_value) {
Review Comment:
from my understanding, const int bound is faster to analysis, and
IntervalSet can build on those constant bounds for further analysis. keeping
them separate makes the design clearer in my view.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
