zhiics opened a new pull request #5365: [FIX][VM] fix fuse over functions that are handled by external codegen URL: https://github.com/apache/incubator-tvm/pull/5365 In #5288, we moved Inline after the second fusion to avoid fusion checks the OpPattern of certain ops that can be eliminated by simplify inference pass, i.e. batch_norm, as external codegen needs to keep them. However, as memory passes should happen as a whole, this may introduce bugs. For example, we may have to bind constants first, like the change in the unit test. This fix reverts the change, but stopping fusing the function that should be handled by external codegen in fuse_op. This indicates that we may need to think about a more systematic way to skip functions inside a pass. Although outlining and inlining was used for the functions that are control by pass manager, it is not sufficient in such case. @vegaluisjose @jroesch @comaniac @tqchen
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
