gemini-code-assist[bot] commented on PR #18421: URL: https://github.com/apache/tvm/pull/18421#issuecomment-3489649231
## Summary of Changes Hello @wrongtest-intellif, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a `step` attribute to the `ForNode` in TVM's Tensor IR (TIR), enabling the representation and generation of loops with non-unit iteration steps. This foundational change impacts various components, from the core IR definition and Python scripting interface to code generation backends and scheduling primitives, ensuring that loops with custom steps are correctly parsed, lowered, and compiled across TVM. ### Highlights * **New `step` attribute for `ForNode`**: Introduced an optional `step` attribute to the `ForNode` in TVM's Tensor IR (TIR), allowing loops to iterate with non-unit steps (e.g., `for i in range(0, 100, 3)`). * **Python API and Scripting Support**: Updated the Python `tvm.script.ir_builder.tir` module to accept `step` arguments for `serial`, `parallel`, `vectorized`, and `unroll` loop types. The `tvm.script.parser.tir` now handles Python's `range` sugar with a `step` argument, mapping it to the new TIR `step` attribute. * **Code Generation Updates**: Modified various code generation backends (LLVM, C, WebGPU, SPIRV) to correctly interpret and generate code for loops that include a custom `step` value. This ensures that the new loop semantics are respected during compilation. * **TIR Schedule and Transform Compatibility**: Adjusted numerous TIR scheduling primitives and transformation passes to either propagate the new `step` attribute or utilize the newly introduced `For::ForSimple` constructor, which implicitly assumes a trivial (unit) step. This maintains compatibility and correctness across the TIR pipeline. * **New Utility and Tests**: Added a `HasTrivialStep()` method to `ForNode` for easier checking of unit steps. New test cases were introduced in `test_tir_nodes.py` and `test_tvmscript_parser_tir.py` to validate the functionality of loops with custom steps. <details> <summary><b>Using Gemini Code Assist</b></summary> <br> The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips. <b>Invoking Gemini</b> You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page. Feature | Command | Description --- | --- | --- Code Review | `/gemini review` | Performs a code review for the current pull request in its current state. Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state. Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments. Help | `/gemini help` | Displays a list of available commands. <b>Customization</b> To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). <b>Limitations & Feedback</b> Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG). <b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b> </details> [^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
