This is an automated email from the ASF dual-hosted git repository.

junrushao pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tvm-ffi.git


The following commit(s) were added to refs/heads/main by this push:
     new a999de6  fix: clang tidy issue (#279)
a999de6 is described below

commit a999de6efa7f59b6a120ddc1b762eafc290d45a6
Author: Kathryn (Jinqi) Chen <[email protected]>
AuthorDate: Thu Nov 20 18:41:34 2025 -0800

    fix: clang tidy issue (#279)
---
 src/ffi/testing/testing.cc | 4 ++--
 tests/cpp/test_metadata.cc | 3 +++
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/ffi/testing/testing.cc b/src/ffi/testing/testing.cc
index 876801f..d38c027 100644
--- a/src/ffi/testing/testing.cc
+++ b/src/ffi/testing/testing.cc
@@ -335,9 +335,9 @@ Variant<int64_t, String, Array<int64_t>> schema_variant_mix(
 }
 
 // Complex nested types
-Map<String, Array<int64_t>> schema_arr_map_opt(Array<Optional<int64_t>> arr,
+Map<String, Array<int64_t>> schema_arr_map_opt(const Array<Optional<int64_t>>& 
arr,
                                                Map<String, Array<int64_t>> mp,
-                                               Optional<String> os) {
+                                               const Optional<String>& os) {
   // no-op combine
   if (os.has_value()) {
     Array<int64_t> extra;
diff --git a/tests/cpp/test_metadata.cc b/tests/cpp/test_metadata.cc
index d0dfebd..ddb1abd 100644
--- a/tests/cpp/test_metadata.cc
+++ b/tests/cpp/test_metadata.cc
@@ -31,9 +31,12 @@
 
 // Forward declarations for exported FFI functions
 extern "C" {
+// NOLINTNEXTLINE(bugprone-reserved-identifier)
 int __tvm_ffi__metadata_testing_dll_schema_id_int(void*, const TVMFFIAny*, 
int32_t, TVMFFIAny*);
+// NOLINTNEXTLINE(bugprone-reserved-identifier)
 int __tvm_ffi__metadata_testing_dll_test_add_with_docstring(void*, const 
TVMFFIAny*, int32_t,
                                                             TVMFFIAny*);
+// NOLINTNEXTLINE(bugprone-reserved-identifier)
 int __tvm_ffi__doc_testing_dll_test_add_with_docstring(void*, const 
TVMFFIAny*, int32_t,
                                                        TVMFFIAny*);
 }

Reply via email to