This is an automated email from the ASF dual-hosted git repository.
tqchen pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tvm.git
The following commit(s) were added to refs/heads/main by this push:
new 88a9e91be6 [Fix] Handle empty variable name in NameSupply::FreshName
(#18742)
88a9e91be6 is described below
commit 88a9e91be6ae973bcfbde557b02305809b939c22
Author: Ruihang Lai <[email protected]>
AuthorDate: Tue Feb 10 11:02:04 2026 -0500
[Fix] Handle empty variable name in NameSupply::FreshName (#18742)
Map empty names to "v" to prevent codegen from producing GPU code with
empty variable names that fail compilation. Also fix add_prefix_to_name
to use the (possibly remapped) unique_name instead of the original name.
---
src/ir/name_supply.cc | 6 +++++-
tests/python/ir/test_name_supply.py | 41 +++++++++++++++++++++++++++++++++++++
2 files changed, 46 insertions(+), 1 deletion(-)
diff --git a/src/ir/name_supply.cc b/src/ir/name_supply.cc
index e5b94dff5a..2f7bf501e5 100644
--- a/src/ir/name_supply.cc
+++ b/src/ir/name_supply.cc
@@ -47,8 +47,12 @@ ffi::String NameSupplyNode::ReserveName(const ffi::String&
name, bool add_prefix
ffi::String NameSupplyNode::FreshName(const ffi::String& name, bool add_prefix,
bool add_underscore) {
ffi::String unique_name = name;
+ if (unique_name.empty()) {
+ // Special case for empty name, set to "v".
+ unique_name = "v";
+ }
if (add_prefix) {
- unique_name = add_prefix_to_name(name);
+ unique_name = add_prefix_to_name(unique_name);
}
unique_name = GetUniqueName(unique_name, add_underscore);
return unique_name;
diff --git a/tests/python/ir/test_name_supply.py
b/tests/python/ir/test_name_supply.py
new file mode 100644
index 0000000000..bc3283968d
--- /dev/null
+++ b/tests/python/ir/test_name_supply.py
@@ -0,0 +1,41 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+import tvm
+import tvm.testing
+from tvm.ir.supply import NameSupply
+
+
+def test_fresh_name_empty_string():
+ """Empty name should produce a valid variable name, not an empty string."""
+ ns = NameSupply("")
+ name = ns.fresh_name("", add_prefix=False)
+ assert name == "v"
+ name2 = ns.fresh_name("", add_prefix=False)
+ assert name2 == "v_1"
+
+
+def test_fresh_name_empty_string_with_prefix():
+ """Empty name with prefix should produce a valid variable name."""
+ ns = NameSupply("prefix")
+ name = ns.fresh_name("", add_prefix=True)
+ assert name == "prefix_v"
+ name2 = ns.fresh_name("", add_prefix=True)
+ assert name2 == "prefix_v_1"
+
+
+if __name__ == "__main__":
+ tvm.testing.main()
