This is an automated email from the ASF dual-hosted git repository.
tlopex pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tvm.git
The following commit(s) were added to refs/heads/main by this push:
new 6b27d19497 [REFACTOR][IR] Remove dead AttrFunctor template (#19528)
6b27d19497 is described below
commit 6b27d19497be2e8e1218f598e3213caac8a81da8
Author: Tianqi Chen <[email protected]>
AuthorDate: Sat May 9 15:40:56 2026 -0400
[REFACTOR][IR] Remove dead AttrFunctor template (#19528)
## Summary
`AttrFunctor` is declared infrastructure with no remaining users.
An exhaustive search across `include/`, `src/`, `tests/`, `python/`,
`apps/`, `web/`, and `cmake/` confirms zero subclasses, zero friend
declarations, and zero macro callers outside the header itself —
its two internal macros (`ATTR_FUNCTOR_DEFAULT`,
`ATTR_FUNCTOR_DISPATCH`)
are only used inside `src/ir/attr_functor.h`. The one
`#include "attr_functor.h"` in `src/ir/attrs.cc` is a stale leftover
from a prior migration; that file references only `DictAttrs` and
`AttrFieldInfoNode` (from `tvm/ir/attrs.h`), not any `AttrFunctor`
symbols.
Removes `src/ir/attr_functor.h` (150 lines) and drops the stale include.
No build-system changes needed — the header was never enumerated in
any `CMakeLists.txt`.
---
src/ir/attr_functor.h | 150 --------------------------------------------------
src/ir/attrs.cc | 2 -
2 files changed, 152 deletions(-)
diff --git a/src/ir/attr_functor.h b/src/ir/attr_functor.h
deleted file mode 100644
index 1c80d12d85..0000000000
--- a/src/ir/attr_functor.h
+++ /dev/null
@@ -1,150 +0,0 @@
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied. See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-/*!
- * \file attr_functor.h
- * \brief A way to define arbitrary function signature
- * with dispatch on common attributes.
- *
- * Common attributes include:
- * - int, float, str constants
- * - array of attributes
- * - map of attributes
- */
-#ifndef TVM_IR_ATTR_FUNCTOR_H_
-#define TVM_IR_ATTR_FUNCTOR_H_
-
-#include <tvm/ir/node_functor.h>
-#include <tvm/tirx/expr.h>
-
-#include <utility>
-
-namespace tvm {
-
-template <typename FType>
-class AttrFunctor;
-
-#define ATTR_FUNCTOR_DEFAULT \
- { \
- return VisitAttrDefault_(op, std::forward<Args>(args)...); \
- }
-
-#define ATTR_FUNCTOR_DISPATCH(OP)
\
- vtable.template set_dispatch<OP>([](const ffi::ObjectRef& n, TSelf* self,
Args... args) { \
- return self->VisitAttr_(static_cast<const OP*>(n.get()),
std::forward<Args>(args)...); \
- });
-
-// A functor for common attribute information.
-template <typename R, typename... Args>
-class AttrFunctor<R(const ffi::ObjectRef& n, Args...)> {
- private:
- using TSelf = AttrFunctor<R(const ffi::ObjectRef& n, Args...)>;
- using FType = tvm::NodeFunctor<R(const ffi::ObjectRef& n, TSelf* self,
Args...)>;
-
- public:
- /*! \brief the result type of this functor */
- using result_type = R;
- /*! \brief virtual destructor */
- virtual ~AttrFunctor() {}
- /*!
- * \brief The functor call.
- * \param n The expression node.
- * \param args Additional arguments.
- * \return The result of the call
- */
- virtual R VisitAttr(const ffi::ObjectRef& n, Args... args) {
- static FType vtable = InitVTable();
- if (vtable.can_dispatch(n)) {
- return vtable(n, this, std::forward<Args>(args)...);
- } else {
- return VisitAttrDefault_(n.get(), std::forward<Args>(args)...);
- }
- }
- virtual R VisitAttrDefault_(const ffi::Object* node, Args... args) = 0;
- virtual R VisitAttr_(const ffi::ArrayObj* op, Args... args)
ATTR_FUNCTOR_DEFAULT;
- virtual R VisitAttr_(const tirx::IntImmNode* op, Args... args)
ATTR_FUNCTOR_DEFAULT;
- virtual R VisitAttr_(const tirx::FloatImmNode* op, Args... args)
ATTR_FUNCTOR_DEFAULT;
- virtual R VisitAttr_(const tirx::StringImmNode* op, Args... args)
ATTR_FUNCTOR_DEFAULT;
- // deep comparison of symbolic integer expressions.
- virtual R VisitAttr_(const tirx::VarNode* op, Args... args)
ATTR_FUNCTOR_DEFAULT;
- virtual R VisitAttr_(const tirx::SizeVarNode* op, Args... args) {
- return VisitAttr_(static_cast<const tirx::VarNode*>(op),
std::forward<Args>(args)...);
- }
- virtual R VisitAttr_(const tirx::AddNode* op, Args... args)
ATTR_FUNCTOR_DEFAULT;
- virtual R VisitAttr_(const tirx::SubNode* op, Args... args)
ATTR_FUNCTOR_DEFAULT;
- virtual R VisitAttr_(const tirx::MulNode* op, Args... args)
ATTR_FUNCTOR_DEFAULT;
- virtual R VisitAttr_(const tirx::DivNode* op, Args... args)
ATTR_FUNCTOR_DEFAULT;
- virtual R VisitAttr_(const tirx::ModNode* op, Args... args)
ATTR_FUNCTOR_DEFAULT;
- virtual R VisitAttr_(const tirx::FloorDivNode* op, Args... args)
ATTR_FUNCTOR_DEFAULT;
- virtual R VisitAttr_(const tirx::FloorModNode* op, Args... args)
ATTR_FUNCTOR_DEFAULT;
- virtual R VisitAttr_(const tirx::MinNode* op, Args... args)
ATTR_FUNCTOR_DEFAULT;
- virtual R VisitAttr_(const tirx::MaxNode* op, Args... args)
ATTR_FUNCTOR_DEFAULT;
- virtual R VisitAttr_(const tirx::GENode* op, Args... args)
ATTR_FUNCTOR_DEFAULT;
- virtual R VisitAttr_(const tirx::GTNode* op, Args... args)
ATTR_FUNCTOR_DEFAULT;
- virtual R VisitAttr_(const tirx::LTNode* op, Args... args)
ATTR_FUNCTOR_DEFAULT;
- virtual R VisitAttr_(const tirx::LENode* op, Args... args)
ATTR_FUNCTOR_DEFAULT;
- virtual R VisitAttr_(const tirx::EQNode* op, Args... args)
ATTR_FUNCTOR_DEFAULT;
- virtual R VisitAttr_(const tirx::NENode* op, Args... args)
ATTR_FUNCTOR_DEFAULT;
- virtual R VisitAttr_(const tirx::AndNode* op, Args... args)
ATTR_FUNCTOR_DEFAULT;
- virtual R VisitAttr_(const tirx::OrNode* op, Args... args)
ATTR_FUNCTOR_DEFAULT;
- virtual R VisitAttr_(const tirx::NotNode* op, Args... args)
ATTR_FUNCTOR_DEFAULT;
- virtual R VisitAttr_(const tirx::CastNode* op, Args... args)
ATTR_FUNCTOR_DEFAULT;
- virtual R VisitAttr_(const tirx::CallNode* op, Args... args)
ATTR_FUNCTOR_DEFAULT;
- virtual R VisitAttr_(const tirx::SelectNode* op, Args... args)
ATTR_FUNCTOR_DEFAULT;
-
- private:
- // initialize the vtable.
- static FType InitVTable() {
- using namespace tirx;
- FType vtable;
- // Set dispatch
- ATTR_FUNCTOR_DISPATCH(ffi::ArrayObj);
- ATTR_FUNCTOR_DISPATCH(IntImmNode);
- ATTR_FUNCTOR_DISPATCH(FloatImmNode);
- ATTR_FUNCTOR_DISPATCH(StringImmNode);
- ATTR_FUNCTOR_DISPATCH(VarNode);
- ATTR_FUNCTOR_DISPATCH(SizeVarNode);
- ATTR_FUNCTOR_DISPATCH(AddNode);
- ATTR_FUNCTOR_DISPATCH(SubNode);
- ATTR_FUNCTOR_DISPATCH(MulNode);
- ATTR_FUNCTOR_DISPATCH(DivNode);
- ATTR_FUNCTOR_DISPATCH(ModNode);
- ATTR_FUNCTOR_DISPATCH(FloorDivNode);
- ATTR_FUNCTOR_DISPATCH(FloorModNode);
- ATTR_FUNCTOR_DISPATCH(MinNode);
- ATTR_FUNCTOR_DISPATCH(MaxNode);
- ATTR_FUNCTOR_DISPATCH(GENode);
- ATTR_FUNCTOR_DISPATCH(GTNode);
- ATTR_FUNCTOR_DISPATCH(LENode);
- ATTR_FUNCTOR_DISPATCH(LTNode);
- ATTR_FUNCTOR_DISPATCH(EQNode);
- ATTR_FUNCTOR_DISPATCH(NENode);
- ATTR_FUNCTOR_DISPATCH(AndNode);
- ATTR_FUNCTOR_DISPATCH(OrNode);
- ATTR_FUNCTOR_DISPATCH(NotNode);
- ATTR_FUNCTOR_DISPATCH(CastNode);
- ATTR_FUNCTOR_DISPATCH(CallNode);
- ATTR_FUNCTOR_DISPATCH(SelectNode);
- vtable.Finalize();
- return vtable;
- }
-};
-
-} // namespace tvm
-#endif // TVM_IR_ATTR_FUNCTOR_H_
diff --git a/src/ir/attrs.cc b/src/ir/attrs.cc
index 008729022f..cfe269e4eb 100644
--- a/src/ir/attrs.cc
+++ b/src/ir/attrs.cc
@@ -24,8 +24,6 @@
#include <tvm/ffi/reflection/registry.h>
#include <tvm/ir/attrs.h>
-#include "attr_functor.h"
-
namespace tvm {
TVM_FFI_STATIC_INIT_BLOCK() {
